Remove Deref from peripheral singletons #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
peripheral
branch
4 times, most recently
from
0a8a879 to
7deaba6
Compare
bugadani
force-pushed
the
peripheral
branch
2 times, most recently
from
f64e0e6 to
62d7531
Compare
bugadani
force-pushed
the
peripheral
branch
5 times, most recently
from
5efbe85 to
55db8da
Compare
SergioGasquez
approved these changes
Jan 21, 2025
Thanks for bringing that up! I think this abbreviation is fine in this instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Deref implementation from peripheral singletons. Instead, a
register_block(&self)and aregs()method (both of them public-unstable) are provided by the peripheral singletons. Drivers usually wrap these in a.regs(&self). This change removes stable exposure of PAC types through the Deref trait.cc #2525