Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong kind enum value for ExtensionInstanceRemoveFromContext spec #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: wrong kind enum value for ExtensionInstanceRemoveFromContext spec #420

wants to merge 2 commits into from

Conversation

martin-helmich
Copy link
Member

No description provided.

@martin-helmich
Copy link
Member Author

I just also noticed #422, which is contradictory to this one. It is ExtensionInstanceRemovedFromContext (in which case #422 is wrong), or is it InstanceRemovedFromContext (in which case this PR is wrong)?

@tdellmann
Copy link
Contributor

I just also noticed #422, which is contradictory to this one. It is ExtensionInstanceRemovedFromContext (in which case #422 is wrong), or is it InstanceRemovedFromContext (in which case this PR is wrong)?

The values set in #422 are copied from the code. These are the ones that get send via webhook. I will close this PR and do the changes in #422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freisenhauer freisenhauer freisenhauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-helmich @tdellmann @freisenhauer