Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong kind enum value for ExtensionInstanceRemoveFromContext spec #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: wrong kind enum value for ExtensionInstanceRemoveFromContext spec #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c85211
fix: wrong kind enum value for ExtensionInstanceRemoveFromContext spec
martin-helmich Feb 6, 2025
6b21354
fix: additional syntax errors
martin-helmich Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/contribution/50-reference/4-webhooks.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ You may use the following placeholders:
},
kind: {
type: "string",
enum: ["ExtensionInstanceUpdated"],
enum: ["ExtensionInstanceRemovedFromContext"],
},
id: {
type: "string",
Expand Down Expand Up @@ -595,11 +595,11 @@ This ensures that the request body was transmitted by mittwald and was not modif
```go
bodyBytes, err := io.ReadAll(body)
if err != nil {
return err
return err
}

if !ed25519.Verify(publicKey, bodyBytes, signature) {
panic("invalid signature")
panic("invalid signature")
}
```

Expand Down
12 changes: 7 additions & 5 deletions ...docusaurus-plugin-content-docs/current/contribution/50-reference/4-webhooks.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ Folgende Platzhalter können verwendet werden:
},
kind: {
type: "string",
enum: ["ExtensionInstanceUpdated"],
enum: ["ExtensionInstanceRemovedFromContext"],
},
id: {
type: "string",
Expand Down Expand Up @@ -587,19 +587,21 @@ Um die Signatur zu prüfen, kann eine übliche kryptographische Library in der g

<Tabs>
<TabItem value="go" label="Go">

```go
bodyBytes, err := io.ReadAll(body)
if err != nil {
return err
return err
}

if !ed25519.Verify(publicKey, bodyBytes, signature) {
panic("invalid signature")
panic("invalid signature")
}
```

````
</TabItem>
<TabItem value="php" label="PHP">

```php
$req = new ExtensionGetPublicKeyRequest($serial);
$resp = $apiClient->marketplace()->extensionGetPublicKey($req);
Expand All @@ -614,7 +616,7 @@ $valid = sodium_crypto_sign_verify_detached(
if (!$valid) {
throw new \Exception('invalid request signature');
}
````
```

</TabItem>
</Tabs>
Expand Down
Loading