DO NOT MERGE: Remove GARD - Build #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
added
the
build
joeflack4
force-pushed
the
remove-gard-build
branch
from
2466301 to
3d7a20b
Compare
joeflack4
force-pushed
the
remove-gard-build
branch
from
3d7a20b to
bd51c80
Compare
joeflack4
commented
Oct 22, 2024
There was a problem hiding this comment.
New file in this build, FYI.
There was a problem hiding this comment.
Thanks for pointing this out. New or deleted files under lexmatch/split-mapping-set are not concerning since these split-mapping-set files are just subsets of the overall lexmatch files and some variance would be expected between runs. E.g. one run may have a new closematch entry that then creates a new file in lexmatch/split-mapping-set.
twhetzel
reviewed
Oct 24, 2024
| @@ -217,7 +217,7 @@ MONDO:0007060 skos:exactMatch OMIM:102530 spermatogenic failure 6 semapv:Unspec | |||
| MONDO:0007061 skos:exactMatch OMIM:102590 semapv:UnspecifiedMatching | |||
| MONDO:0007062 skos:exactMatch OMIM:102650 adactylia, unilateral semapv:UnspecifiedMatching | |||
| MONDO:0007064 skos:exactMatch OMIM:102700 severe combined immunodeficiency, autosomal recessive, t cell-negative, B cell-negative, nk cell-negative, due to adenosine deaminase deficiency semapv:UnspecifiedMatching | |||
| MONDO:0007066 skos:exactMatch OMIM:102800 adenosine triphosphatase deficiency, anemia due to semapv:UnspecifiedMatching | |||
| MONDO:0007066 skos:exactMatch OMIM:102800 semapv:UnspecifiedMatching | |||
There was a problem hiding this comment.
Unrelated to this PR, however this OMIM entry, without a label, has been moved to a new entry, https://www.omim.org/entry/102800, so this should not show up as an exactMatch.
OMIM ticket monarch-initiative/omim#157
twhetzel
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for: