qc-duplicate-exact-synonym-no-abbrev related updates
#767
+142
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Further updates to scripting that prevents multiple exact synonyms from appearing on different Mondo IDs. - Bug fix: synonyms-scope-type-xref(.sparql/.tsv) was missing cls_labe. This was causing a KeyError. Not sure how the code was running successfully without this before. - Update: No longer filtering -updated.
- Update: Now has different paths for input/output files, instead of mutating the inputs. - Delete: Code for backing up the inputs. No longer needed, as there are no longer mutations.
- Add: Docs for reports/sync-synonym/review-qc-duplicate-exact-synonym-no-abbrev.tsv
- Update: Finished updating parameterization regrarding change of input/output dirs - Note that this update also gets fixes the spurious / confusing diffs issue - Update: Added logic to handle errors in case of no issues detected
- Bug fix: ImportError
joeflack4
changed the title
qc-duplicate-exact-synonym-no-abbrev related upatesqc-duplicate-exact-synonym-no-abbrev related updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Overview
Further updates to scripting that prevents multiple exact synonyms from appearing on different Mondo IDs.
Most important change:
-updatedtemplates.Other changes:
reports/sync-synonym/review-qc-duplicate-exact-synonym-no-abbrev.tsvintoreports/README.mdPre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?Mini build:
qc-duplicate-exact-synonym-no-abbrevrelated updates - mini build #770Build:
qc-duplicate-exact-synonym-no-abbrevrelated updates - build #771New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Additional notes
qc-duplicate-exact-synonym-no-abbrevfailures inmondo#751