-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getPlayerInfo again #850
Conversation
What was this even supposed to do
There's a chance it might be undefined so isBanned won't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code isn't usable at present -we need to find the source of the 429s. If we need to drop functionality so be it
Is Arguably, we may want to deprecate this function altogether, and add a |
Yeah the request rate is 1/2 per minute on a clean residential ip. This arguably should be deprecates but that wasn't brought up when this was first opened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…fails with a HTTP 429
getPlayerInfo is being deprecated in favor of the individualized endpoints - this inherently solves the 429 issue to the best possible
There are three issues which this solves
.body
property on the body itself since that change and I forgot to change that beforehand.User does not exist
regardless of what the true error was, now the error(s) is actually logged.EDIT: Also drops
getUsernameHistory
so people don't get ratelimited all the time.