Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getPlayerInfo again #850

Merged
merged 12 commits into from
Feb 13, 2025
Merged

Conversation

Regalijan
Copy link
Member

@Regalijan Regalijan commented Dec 13, 2024

There are three issues which this solves

  • The returned response/value object was never an array to begin with and that finally stopped working at some point that I can't figure out (which is now made moot by the fact that we no longer return response objects since Split getPlayerInfo into smaller methods #840)
  • We were accessing the .body property on the body itself since that change and I forgot to change that beforehand.
  • We would throw User does not exist regardless of what the true error was, now the error(s) is actually logged.

EDIT: Also drops getUsernameHistory so people don't get ratelimited all the time.

@Regalijan Regalijan requested a review from Neztore December 13, 2024 22:06
There's a chance it might be undefined so isBanned won't exist
Copy link
Member

@Neztore Neztore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code isn't usable at present -we need to find the source of the 429s. If we need to drop functionality so be it

@Regalijan Regalijan requested a review from Neztore December 16, 2024 19:09
@alanbixby
Copy link
Member

Is getUsernameHistory the source of the 429's - I was under the impression it was the follower endpoints?

Arguably, we may want to deprecate this function altogether, and add a console.warn if it 429's pointing to the new split off methods in #840 and then stage a new release.

@Regalijan
Copy link
Member Author

Yeah the request rate is 1/2 per minute on a clean residential ip.

This arguably should be deprecates but that wasn't brought up when this was first opened.

Copy link
Member

@alanbixby alanbixby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Receiving rate limits on follower endpoints on a residential IP within ~15 reqs/min - going to deprecate this and trigger a banner pointing to the individualized endpoints

image

@alanbixby alanbixby dismissed Neztore’s stale review February 13, 2025 01:03

getPlayerInfo is being deprecated in favor of the individualized endpoints - this inherently solves the 429 issue to the best possible

@alanbixby alanbixby merged commit cf9a027 into noblox:master Feb 13, 2025
2 checks passed
@Regalijan Regalijan deleted the fix-getplayer-info-again branch February 13, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants