Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getPlayerInfo again #850

Merged
merged 12 commits into from
Feb 13, 2025
Merged

Fix getPlayerInfo again #850

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1c91c4
Don't look for redundant body property
Regalijan Dec 13, 2024
5019054
Remove instanceof Array check
Regalijan Dec 13, 2024
86800d5
Actually return error reason instead of lying about the user not exis…
Regalijan Dec 13, 2024
6765b75
Optional chain userBody
Regalijan Dec 13, 2024
850d1ab
Stringify error bodies
Regalijan Dec 13, 2024
7df89c3
Remove username history from getPlayerInfo
Regalijan Dec 13, 2024
7d91455
Apparently thaty's why it wasn't working
Regalijan Dec 13, 2024
6985bf4
Fix error parsing in getUserInfo
Regalijan Dec 13, 2024
e0138d0
Remove stray comma
Regalijan Dec 13, 2024
5b79e43
Don't reject for zero failures
Regalijan Dec 13, 2024
988bf59
chore: deprecate getPlayerInfo, add a warning banner if the endpoint …
alanbixby Feb 13, 2025
57b2d17
fix linting and show_deprecation_warning flag logic
alanbixby Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions lib/users/getPlayerInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,10 @@ function getPlayerInfo (userId) {

Promise.all(requests).then((promiseResponses) => {
const responses = promiseResponses.map(response => response.value)
const usersResponse = responses[0]
const userBody = usersResponse ? usersResponse.body : {}
const failedResponse = promiseResponses.find(presponse => presponse.status === 'rejected') || responses.find(response => !response || (!(response instanceof Array) && (response.statusCode !== 200 || !response.body)))
const userBody = responses[0]
const failedResponses = promiseResponses.filter(presponse => presponse.status === 'rejected')

if (userBody.isBanned) {
if (userBody?.isBanned) {
const joinDate = new Date(userBody.created)
const blurb = userBody.description
const isBanned = userBody.isBanned
Expand All @@ -53,8 +52,8 @@ function getPlayerInfo (userId) {
isBanned,
displayName
})
} else if (failedResponse) {
reject(new Error('User does not exist.'))
} else if (failedResponses) {
reject(new Error(failedResponses.map(r => r.reason).join('\n')))
} else {
const responseBodies = responses.map(res => res.body ?? res)
const oldNames = responses[4].map(nameObject => nameObject.name) || []
Expand Down
Loading