Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uplift to polkadot 2412 #425

Conversation

peterwht
Copy link
Collaborator

@peterwht peterwht commented Jan 9, 2025

@peterwht peterwht changed the base branch from main to chore-upgrade-pop-net-to-stable2412/sc-1940 January 9, 2025 22:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 22.34043% with 73 lines in your changes missing coverage. Please review.

Project coverage is 71.28%. Comparing base (5c4b865) to head (937ca11).

Files with missing lines Patch % Lines
runtime/devnet/src/config/api/versioning.rs 0.00% 15 Missing ⚠️
runtime/testnet/src/config/api/versioning.rs 0.00% 15 Missing ⚠️
node/src/command.rs 0.00% 13 Missing ⚠️
node/src/service.rs 0.00% 12 Missing ⚠️
node/src/chain_spec.rs 0.00% 6 Missing ⚠️
pallets/nfts/src/features/transfer.rs 0.00% 2 Missing ⚠️
pallets/nfts/src/impl_nonfungibles.rs 0.00% 2 Missing ⚠️
primitives/src/lib.rs 88.23% 2 Missing ⚠️
extension/src/functions.rs 80.00% 0 Missing and 1 partial ⚠️
pallets/nfts/src/benchmarking.rs 0.00% 1 Missing ⚠️
... and 4 more
@@                               Coverage Diff                               @@
##           chore-upgrade-pop-net-to-stable2412/sc-1940     #425      +/-   ##
===============================================================================
- Coverage                                        71.35%   71.28%   -0.07%     
===============================================================================
  Files                                               72       72              
  Lines                                            13592    13626      +34     
  Branches                                         13592    13626      +34     
===============================================================================
+ Hits                                              9698     9713      +15     
- Misses                                            3627     3646      +19     
  Partials                                           267      267              
Files with missing lines Coverage Δ
extension/src/lib.rs 94.23% <100.00%> (ø)
pallets/api/src/mock.rs 100.00% <ø> (ø)
pallets/nfts/src/common_functions.rs 90.25% <100.00%> (ø)
extension/src/functions.rs 92.41% <80.00%> (ø)
pallets/nfts/src/benchmarking.rs 85.79% <0.00%> (ø)
pallets/nfts/src/lib.rs 70.77% <0.00%> (ø)
runtime/devnet/src/lib.rs 5.44% <0.00%> (ø)
runtime/mainnet/src/lib.rs 21.44% <0.00%> (ø)
runtime/testnet/src/lib.rs 6.29% <0.00%> (ø)
pallets/nfts/src/features/transfer.rs 83.68% <0.00%> (ø)
... and 7 more

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good, I faced a similar issue with the integration tests when I made similar changes to the Cargo.toml file. Left a few things and also curious what the order of things will be with the linked PRs?

node/src/service.rs Outdated Show resolved Hide resolved
pallets/nfts/src/benchmarking.rs Show resolved Hide resolved
primitives/src/lib.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/lib.rs Show resolved Hide resolved
@peterwht peterwht force-pushed the peterwht/chore-polkadot-2412 branch from 029a3a9 to 937ca11 Compare January 17, 2025 02:50
Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uplift looks pretty good! looking forward to seeing the CI green!

As it has been discussed off github there are a few improvements that can be made to the mainnet runtime. But having this PR only taking care of the sdk sync makes sense to me.

I'm happy to take care of working on pushing those runtime changes, @peterwht

integration-tests/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this needs to get wrapped up but could we add a story for creating a message to twitter and telegram regarding the new TrieError.

primitives/src/lib.rs Outdated Show resolved Hide resolved
primitives/src/lib.rs Outdated Show resolved Hide resolved
primitives/src/lib.rs Outdated Show resolved Hide resolved
@peterwht peterwht merged commit 6bfb27d into chore-upgrade-pop-net-to-stable2412/sc-1940 Jan 21, 2025
3 checks passed
@peterwht peterwht deleted the peterwht/chore-polkadot-2412 branch January 21, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants