-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: uplift to polkadot 2412 #425
chore: uplift to polkadot 2412 #425
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chore-upgrade-pop-net-to-stable2412/sc-1940 #425 +/- ##
===============================================================================
- Coverage 71.35% 71.28% -0.07%
===============================================================================
Files 72 72
Lines 13592 13626 +34
Branches 13592 13626 +34
===============================================================================
+ Hits 9698 9713 +15
- Misses 3627 3646 +19
Partials 267 267
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looking good, I faced a similar issue with the integration tests when I made similar changes to the Cargo.toml
file. Left a few things and also curious what the order of things will be with the linked PRs?
…nstead of then_some https://github.com/paritytech/polkadot-sdk/pull/6156/files#diff-7ab065c73b2237dff7c6eca18162b7f674e5e7f9e330af668cc5d35de6a597bd https://github.com/paritytech/polkadot-sdk/pull/5919/files#diff-7b805930c8caa346a498254e233963501862a29b4ae5633a00efb96b9c96258a paritytech/polkadot-sdk#5693 paritytech/polkadot-sdk@b76e91a
029a3a9
to
937ca11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The uplift looks pretty good! looking forward to seeing the CI green!
As it has been discussed off github there are a few improvements that can be made to the mainnet runtime. But having this PR only taking care of the sdk sync makes sense to me.
I'm happy to take care of working on pushing those runtime changes, @peterwht
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as this needs to get wrapped up but could we add a story for creating a message to twitter and telegram regarding the new TrieError
.
6bfb27d
into
chore-upgrade-pop-net-to-stable2412/sc-1940
Uplifts to Stable 2412.
Due to dependency issues with
asset-hub-westend-runtime
with the 2412 release,integration-tests
have been included from the workspace. The integration tests have been updated and confirmed to pass.Relevant PRs causing node changes
Relevant PRs causing runtime changes
sp_runtime::RuntimeString
and replace withCow<'static, str>
orString
depending on use case paritytech/polkadot-sdk#5693TransactionExtension
as a replacement forSignedExtension
paritytech/polkadot-sdk#3685dispatch_info
changing to holdcall_weight
andextension_weight
TODOs (in follow up PRs, non-blocking for this PR)
TransactionExtension
as a replacement forSignedExtension
paritytech/polkadot-sdk#3685