[refactor][kubectl-plugin] require one posarg in session
#3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
patch41
branch
2 times, most recently
from
838854d to
e7b641e
Compare
|
We lose a little bit of info in the error message, but this might be worth being more Cobra-like and having net fewer lines of code. |
command with Cobra's built-in `cobra.ExactArgs(1)` instead of writing our own logic. ## Before ```console $ kubectl ray session Error: session (RAYCLUSTER | TYPE/NAME) See 'ray session -h' for help and examples ``` ## After ```console $ kubectl ray session Error: accepts 1 arg(s), received 0 ``` Signed-off-by: David Xia <[email protected]>
|
Maybe it's just me, but I think the old output was more helpful Because it showed what the missing required argument was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command with Cobra's built-in
cobra.ExactArgs(1)instead of writing our ownlogic.
Before
After
Signed-off-by: David Xia [email protected]
Checks