Handle Predis Exception when Database is Out of Bounds. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[v2.3.0] Bump Plugin Version and Update Readme Files
Pathan-Amaankhan
approved these changes
Dec 23, 2024
admin/class-predis-purger.php
Outdated
| @@ -60,14 +60,16 @@ public function __construct() { | |||
|
|
|||
| try { | |||
| $this->redis_object->connect(); | |||
|
|
|||
| if( $nginx_helper_admin->options['redis_database'] !== 0 ) { | |||
There was a problem hiding this comment.
Suggested change
| if( $nginx_helper_admin->options['redis_database'] !== 0 ) { | |
| if( 0 !== $nginx_helper_admin->options['redis_database'] ) { |
admin/class-predis-purger.php
Outdated
| @@ -43,7 +43,7 @@ public function __construct() { | |||
| $username = $nginx_helper_admin->options['redis_username']; | |||
| $password = $nginx_helper_admin->options['redis_password']; | |||
|
|
|||
| if( empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) { | |||
| if( !empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) { | |||
There was a problem hiding this comment.
Suggested change
| if( !empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) { | |
| if( ! empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) { |
admin/class-predis-purger.php
Outdated
| @@ -60,14 +60,16 @@ public function __construct() { | |||
|
|
|||
| try { | |||
| $this->redis_object->connect(); | |||
|
|
|||
| if( $nginx_helper_admin->options['redis_database'] !== 0 ) { | |||
| $this->redis_object->select($nginx_helper_admin->options['redis_database']); | |||
There was a problem hiding this comment.
Suggested change
| $this->redis_object->select($nginx_helper_admin->options['redis_database']); | |
| $this->redis_object->select( $nginx_helper_admin->options['redis_database'] ); |
admin/class-predis-purger.php
Outdated
| if( $nginx_helper_admin->options['redis_database'] !== 0 ) { | ||
| $this->redis_object->select($nginx_helper_admin->options['redis_database']); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove additional new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to handle the exception when the database number for Predis is out of bounds.
Type
Reference Issue
Testing
The code has been tested locally and is working as expected.