Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Predis Exception when Database is Out of Bounds. #376

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Handle Predis Exception when Database is Out of Bounds. #376

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6946181
Merge pull request #373 from rtCamp/release/2.3.0
Vedant-Gandhi Dec 23, 2024
f9d43b9
fix: predis database crashes when the db is out of bounds.
Vedant-Gandhi Dec 23, 2024
3e41f75
fix: invalid empty unix socket path.
Vedant-Gandhi Dec 23, 2024
08db871
refactor: added yoda for database connection.
Vedant-Gandhi Dec 23, 2024
1dd31f2
refactor: remove extra lines.
Vedant-Gandhi Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions admin/class-predis-purger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function __construct() {
$username = $nginx_helper_admin->options['redis_username'];
$password = $nginx_helper_admin->options['redis_password'];

if( empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) {
if( !empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if( !empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) {
if( ! empty( $nginx_helper_admin->options['redis_unix_socket'] ) ) {

$predis_args['path'] = $nginx_helper_admin->options['redis_unix_socket'];
} else {
$predis_args['host'] = $nginx_helper_admin->options['redis_hostname'];;
Expand All @@ -60,14 +60,16 @@ public function __construct() {

try {
$this->redis_object->connect();

if( $nginx_helper_admin->options['redis_database'] !== 0 ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if( $nginx_helper_admin->options['redis_database'] !== 0 ) {
if( 0 !== $nginx_helper_admin->options['redis_database'] ) {

$this->redis_object->select($nginx_helper_admin->options['redis_database']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->redis_object->select($nginx_helper_admin->options['redis_database']);
$this->redis_object->select( $nginx_helper_admin->options['redis_database'] );

}
} catch ( Exception $e ) {
$this->log( $e->getMessage(), 'ERROR' );
return;
}

if( $nginx_helper_admin->options['redis_database'] !== 0 ) {
$this->redis_object->select($nginx_helper_admin->options['redis_database']);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove additional new line.


}

Expand Down
Loading