Update jest, typescript, babel, eslint-config-seek and minimum node version requirement
#709
Conversation
🦋 Changeset detectedLatest commit: f3fde7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like one snapshot needs to be updated. Unrelated, seems like we're running Validate / Lint & Test on both on:
pull_request:
push:
branches: [master]with the caveat it doesn't run on push before opening a PR. I don't necessarily see this as a downside — if you want that check to run, open a draft PR. |
- The issue linked was fixed a long time ago jestjs/jest#6792
askoufis
changed the title
jest, eslint-config-seek and minimum node version requirementjest, typescript, eslint-config-seek and minimum node version requirement
| @@ -152,7 +153,7 @@ | |||
| "traverse": "^0.6.6", | |||
| "treat": "^2.0.4", | |||
| "tree-kill": "^1.2.1", | |||
| "typescript": ">=4.1.3 <4.5.0", | |||
| "typescript": "^4.5.0", | |||
There was a problem hiding this comment.
This goes straight to latest, 4.8.4. Do we want to use ~4.5.0 to stay on 4.5.x?
Lines 16975 to 16976 in b03adb4
There was a problem hiding this comment.
Skuba does this, though I'm not exactly sure of the benefit in the case of sku. If anything, I feel like we'd want to restrict the upper limit, since typescript doesn't adhere to semver, just in case something breaks, but I'm not sure about restricting to a specific minor version as that feels a bit too limiting.
…eps in `yarn.lock`
askoufis
changed the title
jest, typescript, eslint-config-seek and minimum node version requirementjest, typescript, babel, eslint-config-seek and minimum node version requirement
See changesets.
Note:
eslintwas not updated becauseeslint-plugin-cypressis not compatible witheslint8. It's being moved to the cypress repo soon, so will hopefully be updated to support after that's complete.