-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jest
, typescript
, babel
, eslint-config-seek
and minimum node version requirement
#709
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ee3fb13
Update dependencies and node engine requirement
askoufis 6abf910
Fix lint error
askoufis eb8fc69
Add changesets
askoufis 0f197ec
Remove unnecessary jest config
askoufis bdad9e1
Update `ccsModulesTransform` to conform to the new return type
askoufis 0fa9376
Update snapshots
askoufis b03adb4
Update `jest-environment-jsdom` and `typescript` deps
askoufis 2d79603
Change `major` to `minor` in changesets
askoufis e61e3ed
Update jest changeset
askoufis 14f87d8
Update node changeset
askoufis bd2b5c9
Update babel deps to support latest typescript syntax, dedupe babel d…
askoufis 4b7f8b1
Update lockfile
askoufis b9b3df4
Set node engines to `>=14.15` because `less-loader` requires it
askoufis f3fde7c
Update snapshots for the billionth time
askoufis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
'sku': minor | ||
--- | ||
|
||
Update to eslint-config-seek v10 | ||
|
||
This update involves a few major version jumps, so be sure to read the following release notes for all the breaking changes: | ||
- [v8.0.0](https://github.com/seek-oss/eslint-config-seek/releases/tag/v8.0.0) | ||
- [v9.0.0](https://github.com/seek-oss/eslint-config-seek/releases/tag/v9.0.0) | ||
- [v10.0.0](https://github.com/seek-oss/eslint-config-seek/releases/tag/v10.0.0) | ||
|
||
You should be able to automatically fix most lint warnings/errors by running `yarn sku format`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
'sku': minor | ||
--- | ||
|
||
Upgrade from jest v27 to v29 | ||
|
||
Please take a look at the following upgrade guides as there may be breaking changes that affect your tests: | ||
- [v27 to v28 upgrade guide](https://jestjs.io/docs/28.x/upgrading-to-jest28) | ||
- [v28 to v29 upgrade guide](https://jestjs.io/docs/upgrading-to-jest29) | ||
|
||
Likely the most significant change is the new default snapshot format: | ||
|
||
```diff | ||
- Expected: \\"a\\" | ||
+ Expected: "a" | ||
|
||
- Object { | ||
- Array [] | ||
- } | ||
+ { | ||
+ [] | ||
+ } | ||
``` | ||
|
||
This may require you to update your snapshots. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'sku': minor | ||
--- | ||
|
||
Drop support for Node v12 | ||
|
||
Sku now only supports Node v14 and above. | ||
Although sku itself does not depend on any Node v14 APIs, Node v12 is [no longer officially supported](https://github.com/nodejs/Release#end-of-life-releases), and many of sku's dependencies no longer support it either. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
'sku': minor | ||
--- | ||
|
||
Update typescript dependency | ||
|
||
Sku now has a `typescript` dependency of `^4.5.0`. | ||
Previously the version was restricted due to a type issue with `braid-design-system` and `[email protected]`. | ||
Please take a look at the release notes for recent typescript versions as there may be breaking changes that need to be addressed. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes straight to latest,
4.8.4
. Do we want to use~4.5.0
to stay on4.5.x
?sku/yarn.lock
Lines 16975 to 16976 in b03adb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skuba does this, though I'm not exactly sure of the benefit in the case of sku. If anything, I feel like we'd want to restrict the upper limit, since typescript doesn't adhere to semver, just in case something breaks, but I'm not sure about restricting to a specific minor version as that feels a bit too limiting.