fix: make proposals queries reactive by accepting MaybeRefOrGetter #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously our proposals queries were not reactive as they should, because we only accepted rawValues. However we should make those values refs, so queries are properly reactive. We do this by following composables recommendation and making all values accept MaybeRefOrGetter: https://vuejs.org/guide/reusability/composables.html#input-arguments Lack of this reactivity caused bunch of issues as we migrated to use vue-query for Spaces. This might not have any effect in current state (so it's more of a refactor now), but is needed for resubmit of that PR.
Sekhmet
commented
Feb 14, 2025
| @@ -4,43 +4,49 @@ import { | |||
| useQuery, | |||
| useQueryClient | |||
| } from '@tanstack/vue-query'; | |||
| import { MaybeRef } from 'vue'; | |||
| import { MaybeRefOrGetter } from 'vue'; | |||
There was a problem hiding this comment.
In Vue 3.3+ accepting getters is recommended way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously our proposals queries were not reactive as they should, because we only accepted rawValues. However we should make those values refs, so queries are properly reactive.
We do this by following composables recommendation and making all values accept MaybeRefOrGetter: https://vuejs.org/guide/reusability/composables.html#input-arguments
Lack of this reactivity caused bunch of issues as we migrated to use vue-query for Spaces. This might not have any effect in current state (so it's more of a refactor now), but is needed for resubmit of that PR.
How to test