Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: stm32wb5mm-dk: add basic board support #67819

Merged

Conversation

javad123javad
Copy link

This patch add the basic board support for the
STM32WB5MM-DK Discovery Kit. At the moment only
debug UART Debug is ported. Other peripherals will be added in the following patches.

erwango
erwango previously approved these changes Jan 19, 2024
This patch add the basic board support for the
STM32WB5MM-DK Discovery Kit. At the moment only
debug UART Debug is ported. Other peripherals will be added
in the following patches.

Signed-off-by: Javad Rahimipetroudi <[email protected]>
@erwango
Copy link
Member

erwango commented Jan 22, 2024

javad123javad force-pushed the add_board_stm32wb5mm-dk branch from 14c4a59 to 76e3e6e
yesterday

@javad123javad Once a PR is approved, don't rebase unless it is required due to rebase conflict. And if you do, please mention it. On reviewer side, unfortunately we have no clue on what changes you made and have to review the complete change set all over again. Then, if there are other changes required, please make them w/o rebasing.

@javad123javad
Copy link
Author

javad123javad force-pushed the add_board_stm32wb5mm-dk branch from 14c4a59 to 76e3e6e
yesterday

@javad123javad Once a PR is approved, don't rebase unless it is required due to rebase conflict. And if you do, please mention it. On reviewer side, unfortunately we have no clue on what changes you made and have to review the complete change set all over again. Then, if there are other changes required, please make them w/o rebasing.

Sure, Thanks, I was not aware of that.

- gnuarmemb
- xtools
ram: 256
flash: 1024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the size available for application, so it should be 876K. Flashing a f/w larger than this will generate an error.
This field is only used by CI (in tree), and it is unlikely CI can generate this size of binary. So this is only for correctness.

Comment on lines +12 to +13
- gpio
- uart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see other stuff, such as adc, ...

Copy link
Contributor

@msmttchr msmttchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@erwango erwango requested a review from fabiobaltieri January 24, 2024 13:06
@carlescufi carlescufi merged commit 8534767 into zephyrproject-rtos:main Jan 24, 2024
20 checks passed
Copy link

Hi @javad123javad!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@kartben
Copy link
Collaborator

kartben commented Jan 26, 2024

@javad123javad
Only catching this now but the documentation page has several rendering glitches and typos that would probably be worth a follow-up commit.

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some problems I spotted, but would be worth a more thorough review + spell checking

********

STM32WB5MMG is an ultra-low-power and small form factor certified 2.4 GHz
wireless module. It supportsBluetooth |reg| Low Energy 5.4, Zigbee |reg| 3.0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space "supportsBluetooth"


STM32WB5MMG is an ultra-low-power and small form factor certified 2.4 GHz
wireless module. It supportsBluetooth |reg| Low Energy 5.4, Zigbee |reg| 3.0,
OpenThread, dynamic, and static concurrent modes, and 802.15.4proprietary
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space: 802.15.4proprietary

Comment on lines +20 to +21
* STM32WB5MMG (1-Mbyte Flash memory, 256-Kbyte SRAM)
- Dual-core 32‑bit (Arm |reg| Cortex |reg|-M4 and M0+)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check indentation in this bullet list so that it does not render oddly (right now it's a "definition list")

Comment on lines +130 to +139
To operate bluetooth on STM32WB5MMG, Cortex-M0 core should be flashed with
a valid STM32WB Coprocessor binaries (either 'Full stack' or 'HCI Layer').
These binaries are delivered in STM32WB Cube packages, under
Projects/STM32WB_Copro_Wireless_Binaries/STM32WB5x/
For compatibility information with the various versions of these binaries,
please check `modules/hal/stm32/lib/stm32wb/hci/README`_
in the hal_stm32 repo.
Note that since STM32WB Cube package V1.13.2, "full stack" binaries are not compatible
anymore for a use in Zephyr and only "HCI Only" versions should be used on the M0
side.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could use empty lines to not render as a big, hard to read, block

Uploading image.png…

:align: center
:alt: STM32WB5MM-DK

More information about the board can be found at the `` `STM32WB5MM-DK on www.st.com`_.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"at the ``" ?


- Bluetooth |reg| 5.4 specification,
- IEEE 802.15.4-2011 PHY and MAC,
- Zigbee|reg| 3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Zigbee|reg|" --> "Zigbee |reg|"

@javad123javad
Copy link
Author

@javad123javad Only catching this now but the documentation page has several rendering glitches and typos that would probably be worth a follow-up commit.

Sure, thanks. I will fix the errors in a new PR

@kartben
Copy link
Collaborator

kartben commented Jan 27, 2024

@javad123javad Only catching this now but the documentation page has several rendering glitches and typos that would probably be worth a follow-up commit.

Sure, thanks. I will fix the errors in a new PR

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants