New Bidir demo for C# #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
pepone,
externl and
InsertCreativityHere
InsertCreativityHere
approved these changes
Feb 12, 2025
| /// Indicates the button pressed when the alarm rang. | ||
| enum ButtonPressed { Snooze, Stop } | ||
|
|
||
| /// Represents a simple alarm clock. It's the "callback" in this demo, and it's implemented by the client. |
There was a problem hiding this comment.
I don't see why we highlight the word "callback" in this sentence, since this is not in the "callback" demo.
There was a problem hiding this comment.
It's a copy and paste from the Callback demo, and I'd rather keep them in sync.
pepone
approved these changes
Feb 12, 2025
externl
approved these changes
Feb 12, 2025
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the bidir demo by a new demo derived from Callback.