New Ice/bidir demo for C++ #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Feb 12, 2025
pepone
approved these changes
Feb 12, 2025
| std::launch::async, | ||
| [alarmClock = std::move(alarmClock), timePoint]() | ||
| { | ||
| // Sleep until the specified time point. |
There was a problem hiding this comment.
I guess is fine for simple demos to no handle exceptions in remote requests.
There was a problem hiding this comment.
Yes, the exception handling is not what this demo is about. Less extra code = clearer demo.
Also, note that an exception does not result in a crash here. We only wait the futures (tasks), never get their results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the C++ counterpart of #291.