[AIE2P] Extend AIESubRegConstrainer for FIFO ops #286
Conversation
andcarminati
requested review from
abhinay-anubola,
abnikant,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
andcarminati
force-pushed
the
andreu.aie2p.tied.regs
branch
from
c3ac93f to
5b69bef
Compare
Covering also *InstrInfo required changes.
andcarminati
force-pushed
the
andreu.aie2p.tied.regs
branch
from
5b69bef to
070c32b
Compare
| $qex2, $p1, $lf1, $r25, $dc1, $dc4 = VLDB_POP_704_3D $plfr1, $d0_3d, implicit-def $srfifo_uf | ||
| $qex2, $p1, $lf1, $r25, $dc2, $dc4 = VLDB_POP_704_3D $plfr1, $d0_3d, implicit-def $srfifo_uf | ||
| $qex2, $p1, $lf1, $r25, $dc3, $dc6 = VLDB_POP_704_3D $plfr1, $d0_3d, implicit-def $srfifo_uf | ||
| $x6, $p1, $lf1, $r25, $dc1, $dc5 = VLDB_POP_512_3D $p0, $lf0, $r24, $d1_3d, implicit-def $srfifo_uf |
| @@ -94,6 +99,8 @@ bool AIE2PPassConfig::addRegAssignAndRewriteOptimized() { | |||
| if (AllocateMRegsFirst) | |||
| addPass(createGreedyRegisterAllocator(onlyAllocateMRegisters)); | |||
| if (EnableStagedRA) { | |||
| addPass(createGreedyRegisterAllocator(onlyAllocatePLFRRegisters)); | |||
| addPass(createAIESuperRegRewriter()); | |||
There was a problem hiding this comment.
Could you extend staged-ra-rewrite.mir with a few cases for PLFR registers?
There was a problem hiding this comment.
Also, it would be nice to have an end-to-end test that showcases the benefit of StagedRA for PLFR registers like we have one for 2D and 3D addressing registers? Maybe a reduced example from Conv2D?
There was a problem hiding this comment.
See llvm/test/CodeGen/AIE/aie2p/addr_1d2d3d.ll
|
|
||
|
|
||
| --- | ||
| name: test_composed_subreg |
There was a problem hiding this comment.
We have the same test in tie-subregs-pass-vld.mir. I suppose this is related to that other outdated comment. Maybe you should rebase?
There was a problem hiding this comment.
They were actually moved/refactored, they are not duplicated.
| %3:edc = COPY $r3 | ||
| %4:ep = COPY $p0 | ||
| %10:ed = REG_SEQUENCE %4, %subreg.sub_mod, %1, %subreg.sub_dim_size, %2, %subreg.sub_dim_stride, %3, %subreg.sub_dim_count | ||
| $x11, %471:eps, %21:eldfiforeg, %22:erf2, %474:edc = VLDA_POP_512_2D %100, %101, %102, %10, implicit-def $srfifo_uf |
There was a problem hiding this comment.
We have the same tests in tie-subregs-pass-vld.mir. Could you update those instead or remove them?
There was a problem hiding this comment.
They were actually moved/refactored, they are not duplicated.
Covering also *InstrInfo required changes. Also includes some test refactoring.
Based on the original work from @gbossu and @khallouh.