Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index should be emitted as either tbi or csi #7385

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tkchafin
Copy link
Contributor

deepvariant will automatically switch to csi index for larger files, but these were not being picked up in the output, causing failure

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

deepvariant will automatically switch to csi index for larger files, but these were not being picked up in the output, causing failure
tkchafin added a commit that referenced this pull request Jan 28, 2025
Same as PR #7385 -- deepvariant will switch to csi but this wasn't being handled, causing error
@tkchafin tkchafin mentioned this pull request Jan 28, 2025
17 tasks
@famosab
Copy link
Contributor

famosab commented Feb 6, 2025

You might need to update the nf-test snapshot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants